[Freeipa-devel] [PATCHES] 116-119 Make LDAP schema retrieval optional

[Petr Viktorin]

On 03/07/2013 01:43 PM, Jan Cholasta wrote:
> Hi,
>
> these patches add flags to LDAPClient and IPAdmin constructors which can
> be used to disable schema retrieval and decoding of attributes. This
> should make interacting with AD easier (see
> <http://www.redhat.com/archives/freeipa-devel/2013-March/msg00076.html>).
>
> Honza

The first three patches look good, except a nitpick below.


In the last patch, I don't see why you added back search_s. Is 
get_entries inadequate in some way?



>>From 33142d7e0a8508a783e1a1b4a7a22525337ce54d Mon Sep 17 00:00:00 2001
> From: Jan Cholasta<jcholast at redhat.com>
> Date: Thu, 7 Mar 2013 10:50:57 +0100
> Subject: [PATCH 1/4] Do not fail if schema cannot be retrieved from LDAP
>   server.
>
> ---
>   ipaserver/ipaldap.py | 16 +++++++++++++---
>   1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/ipaserver/ipaldap.py b/ipaserver/ipaldap.py
[...]
> +            try:
> +                self._schema = schema_cache.get_schema(
> +                    self.uri, self.conn,
> +                    force_update=self._force_schema_updates)
> +            except:

Don't use bare except.


-- 
Petr³