[Freeipa-devel] [PATCH] 260-262 Global trust configuration page

[Petr Vobornik]

On 03/06/2013 01:42 PM, Petr Vobornik wrote:
> On 03/02/2013 08:40 PM, Endi Sukma Dewata wrote:
>> ----- Original Message -----
>>> First two patches are bug fixes which are required for third patch.
>>> Depends on my patch #259 (Combobox keyboard support)
>>>
>>> 1) [PATCH] Fix dirty state update of editable combobox
>>>
>>> Editable combobox didn't update it's dirty state correctly. CB had
>>> it's own internal value changed event, which was incorrectly used. It
>>> was
>>> removed and widget's value_changed event was used instead.
>>
>> ACK.
>
> Pushed to master
>>
>>> 2) [PATCH] Fix handling of no_update flag in Web UI
>>>
>>> There was an incorrect check for no_update flag. Check was performed
>>> as if the flag was an attribute of object not an item of array. Hence,
>>> the flag never caused any effect.
>>
>> ACK.
>
> Pushed to master
>>
>>> 3) [PATCH] Global trust config page
>>>
>>> https://fedorahosted.org/freeipa/ticket/3333
>>
>>> Just two notes:
>>>
>>> ipantfallbackprimarygroup requires a posix group. Our API currently
>>> doesn't support search based on object classes therefore the entity
>>> select widget incorrectly offers non posix groups as well.
>>
>> Are we planning to add the missing functionality? Right now you'll get
>> 'group not found' if you select a non-POSIX group, which is confusing
>> because the group does exist. Possible solutions:
>
>
> Waiting for "[RFE] Add option for filtering groups by type (posix,..) in
> group-find command" to be implemented to solve issue.
>

Triaged to march and implemented. Patch 267 is on review.

This patch is modified accordingly.

8><-----


>>> Another problem is that hidden 'Default SMB Group' is not listed.
>>> Hence it couldn't be set again after a modification. I made the combobox
>>> editable (first usage, so it revealed a bug) to avoid this problem.
>>> User can enter garbage, but the framework should handle that.
>>
>> This is a little difficult to use. You'll need to know that you have to
>> type 'Default SMB Group' to go back to the default and the UI doesn't
>> show that as an acceptable value. Possible solutions:
>>
>> 1. Add the 'Default SMB Group' as the first entry in the drop down list
>> so you can reselect it again. The drop down list doesn't need to be
>> editable.
>>
>> 2. Use radio buttons to separate the default value from other values:
>>
>>    Fallback primary group: (o) Default SMB Group
>>                            ( ) POSIX group: [ drop down list ]
>>
>> Regardless, I think the server API needs to be changed to accept an
>> empty value to go back to the default value instead of taking 'Default
>> SMB Group'. A default value should be simple and not something that will
>> potentially conflict with a non-default value that happens to have the
>> same name.
>
> I agree. Martin is it feasible?

 From other emails: Apparently its not worth the time. So I implemented #1.

3. Found an issue: trusctconfig-show will raise 'not found' error when 
trusts are not configured on a system. It's fixed separately in attached 
patch #268. It has similar behavior as dns pages.

Also I added data .json files to patch 262 and 268, so the static 
version can be used.

>> --
>> Endi S. Dewata
-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0268-Don-t-show-trusts-pages-when-trust-is-not-configured.patch
Type: text/x-patch
Size: 3731 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130312/a391e03f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0262-1-Global-trust-config-page.patch
Type: text/x-patch
Size: 13795 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130312/a391e03f/attachment-0001.bin>