[Freeipa-devel] [PATCH 118] [WIP] Add 389 DS plugin for special idnsSOASerial attribute handling

[Martin Kosek]

On 03/12/2013 03:38 PM, Petr Spacek wrote:
> On 12.3.2013 10:40, Martin Kosek wrote:
>> On 03/11/2013 04:58 PM, Petr Spacek wrote:
>>> Hello list!
>>>
>>> My first patch for FreeIPA is attached :-)
>>>
>>> I managed to add new 389 DS plugin to build system, but the LDAP magic in
>>> installer and updater is too much for my brain.
>>>
>>> Could somebody show me how installer and updater should add new object to
>>> cn=config ? Plugin configuration is static (example is in comments in
>>> ipa_dns.c).
>>>
>>> This patch implements minimal necessary support for idnsSOASerial replication.
>>> I investigating more advanced techniques, but I still see problems with locking
>>> and so on.
>>>
>>> Anyway, this patch should be sufficient for now.
>>>
>>> Commit message:
>>>
>>>      Add 389 DS plugin for special idnsSOASerial attribute handling
>>>
>>>      Default value "1" is added to replicated idnsZone objects
>>>      if idnsSOASerial attribute is missing.
>>>
>>>      https://fedorahosted.org/freeipa/ticket/3347
>>>
>>
>> I did not review the actual plugin yet, I just added a code to configure this
>> plugin during new install and upgrade. Patch attached.
>>
>>
>> Just in daemons/ipa-slapi-plugins/ipa-dns/Makefile.am I noticed some copy&paste
>> errors:
>>
>>
>> +libipa_uuid_la_LIBADD =     \  <<< libipa_uuid??
>> +    $(LDAP_LIBS)        \
>> +    $(UUID_LIBS)        \
>> +    $(NULL)
>> +
>>
>> +EXTRA_DIST =            \
>> +    $(app_DATA)        \   <<< not defined, not needed (I will add it in my
>> patch)
>> +    $(NULL)
>> +
> 
> Fixed version is attached.
> 

Sending a rebased version of my installer/updater patch.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-384-2-configure-ipa_dns-ds-plugin-on-install-and-upgrade.patch
Type: text/x-patch
Size: 5082 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130313/c53411dd/attachment.bin>