[Freeipa-devel] patch for trac 2575

[Martin Kosek]

On 02/21/2013 02:39 PM, Martin Kosek wrote:
> Thanks Brian. I still see few issues though:
> 
> 1) The patch adds a whitespace error:
> 
> $ git apply ~/freeipa-bcook-0001-Add-DNS-Setup-Prompt-to-Install.patch
> /home/mkosek/freeipa-bcook-0001-Add-DNS-Setup-Prompt-to-Install.patch:41:
> trailing whitespace.
> 
> warning: 1 line adds whitespace errors
> 
> 2) It does unrelated and unnecessary changes to the main function:
> 
> --- a/install/tools/ipa-server-install
> +++ b/install/tools/ipa-server-install
> @@ -560,10 +560,16 @@ def set_subject_in_config(realm_name, dm_password,
> suffix, subject_base):
>          conn.disconnect()
> 
>  def main():
> +    """
> +
> +
> +    :return:
> +    """
>      global ds
>      global pw_name
>      global uninstalling
>      global installation_cleanup
> +
>      ds = None
> 
>      safe_options, options = parse_options()
> 
> 3) In the question, I would replace "bind" with "BIND" as this is how the
> project should be spelled. I see that few lines above we also refer to BIND
> with "bind" (it may have caused the confusion), I think this can be fixed too.
> 
> Martin

Hello Brian,

I did not see any response to my mail below so I went ahead and made these
fixes myself as we want this in our next release (updated patch attached).

ACK. Pushed to master.

Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-bcook-0001-2-Add-DNS-Setup-Prompt-to-Install.patch
Type: text/x-patch
Size: 1232 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130321/45b30928/attachment.bin>