[Freeipa-devel] [PATCH] 396 Fix structured DNS record output

[Martin Kosek]

On 03/22/2013 03:04 PM, Petr Viktorin wrote:
> On 03/21/2013 03:01 PM, Martin Kosek wrote:
>> Recent LDAP refactoring replaced entry_attrs regular dict with
>> normalized keys (i.e. lowercase) with LDAPEntry instance which keys
>> may not be normalized. This broke CND command output when
>> --structured and --all options were used.
>>
>> Force lowercase normalization of the LDAPEntry keys in DNS plugin
>> structured format postprocessing. Also add a missing test for
>> DNS record structured output.
>>
>> https://fedorahosted.org/freeipa/ticket/3526
>>
> 
> ACK, it works well now.
> 
> The test is critical to prevent future regressions. The planned DNSEntry
> type-checking will prevent putting dicts in entries; we may need to use plain
> dicts for the output. The question will be where to convert them from entries.
> 

Right, this use case adds another level of complexity to this future refactoring.

Pushed to master.

Thanks,
Martin