[Freeipa-devel] [PATCH 0121] Fix crash during invalid zone reload process

[Adam Tkac]

On Thu, Mar 21, 2013 at 02:19:10PM +0100, Petr Spacek wrote:
> Hello,
> 
>     Fix crash during invalid zone reload process.
> 
> This bug was created during settings refactoring and is present only
> in master, not in v2 branch.

Ack

> From 79594a484f30c6677dd901e7f8285719e31bab6b Mon Sep 17 00:00:00 2001
> From: Petr Spacek <pspacek at redhat.com>
> Date: Thu, 21 Mar 2013 14:13:57 +0100
> Subject: [PATCH] Fix crash during invalid zone reload process.
> 
> Signed-off-by: Petr Spacek <pspacek at redhat.com>
> ---
>  src/ldap_helper.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/ldap_helper.c b/src/ldap_helper.c
> index 6f21b8407e8c01a98ae5b6f916c964432c651fd5..7ac5ceda26cd9d734f94d9195388db879be1959e 100644
> --- a/src/ldap_helper.c
> +++ b/src/ldap_helper.c
> @@ -3503,7 +3503,7 @@ update_record(isc_task_t *task, isc_event_t *event)
>  	ldapdb_rdatalist_t rdatalist;
>  
>  	/* Convert domain name from text to struct dns_name_t. */
> -	settings_set_t *zone_settings = NULL;
> +	settings_set_t *zone_settings;
>  	dns_name_t name;
>  	dns_name_t origin;
>  	dns_name_t prevname;
> @@ -3569,6 +3569,7 @@ update_restart:
>  
>  	/* Do not bump serial during initial database dump. */
>  	if (PSEARCH_ANY(pevent->chgtype)) {
> +		zone_settings = NULL;
>  		CHECK(zr_get_zone_settings(inst->zone_register, &origin, &zone_settings));
>  		CHECK(setting_get_bool("serial_autoincrement", zone_settings,
>  				       &serial_autoincrement));
> -- 
> 1.7.11.7
> 


-- 
Adam Tkac, Red Hat, Inc.