[Freeipa-devel] [PATCH] 0010 Add mkhomedir option to ipa-server-install and ipa-replica-install

Martin Kosek mkosek at redhat.com
Thu Mar 28 07:47:02 UTC 2013


On 03/27/2013 02:32 PM, Tomas Babej wrote:
> On Wed 27 Mar 2013 01:54:49 PM CET, Ana Krivokapic wrote:
>> On 03/27/2013 12:15 PM, Tomas Babej wrote:
>>> On 03/26/2013 07:45 PM, Ana Krivokapic wrote:
>>>> Add the option to create home directories for users on their first login
>>>> to ipa-server-install and ipa-replica-install.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/3515
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Freeipa-devel mailing list
>>>> Freeipa-devel at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>
>>> ACK from the functional point of view.
>>>
>>> Just a nitpick, can you please reformat the patch and fix PEP8 E501
>>> errors?
>>>
>>> I know there's a lot of PEP8 errors and warnings in the whole project
>>> (and we probably need to adress this), however, let us not introduce
>>> new ones.
>>>
>>> Tomas
>>
>> Fixed, thanks.
>> -- 
>> Regards,
>>
>> Ana Krivokapic
>> Associate Software Engineer
>> FreeIPA team
>> Red Hat Inc.
> 
> Thanks. Updated patch works fine, ACK.
> 
> Tomas

Pushed to master, ipa-3-1.

Martin




More information about the Freeipa-devel mailing list