[Freeipa-devel] [PATCH] 0027 Prompt for nameserver IP address in dnszone-add

[Ana Krivokapic]

On 05/10/2013 10:37 PM, Endi Sukma Dewata wrote:
> On 5/10/2013 9:38 AM, Petr Viktorin wrote:
>> On 05/10/2013 03:57 PM, Ana Krivokapic wrote:
>> [...]
>>> Thanks for catching the bugs. Updated patches are attached.
>>
>> Thanks! It works nicely.
>> Endi is doing a quick check of the Javascript, if he doesn't find an
>> issue then ACK.
>>
>> If this still makes it into 3.2.0, please only push the first patch there.
>
> I tried this in the UI:
>
>   Zone name: test.com
>   Authoritative nameserver: ns.sometest.com.
>
> The 'Nameserver IP address' field is still enabled. This is because the name
> server is considered in the zone although it's actually not.
>
> The CLI seems to work fine, it didn't ask for IP address.
>
> The UI probably could be fixed using endsWith(ns, '.' + zone). Everything else
> looks fine. ACK with the fix.
>

Fixed, updated patch attached.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0027-05-Prompt-for-nameserver-IP-address-in-dnszone-add.patch
Type: text/x-patch
Size: 9367 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130512/77df177a/attachment.bin>