[Freeipa-devel] [PATCH] 225 Remove leading zero from IPA_NUM_VERSION

Petr Viktorin pviktori at redhat.com
Mon May 13 13:40:58 UTC 2013


On 05/13/2013 02:58 PM, Rob Crittenden wrote:
> Petr Viktorin wrote:
>> Due to my mistake in commit 9125285, the IPA_NUM_VERSION variable
>> contained a leading zero, so it was treated as octal in Python code.
>> Bumping the development version to 3.2.99 resulted in 030299, an invalid
>> value.
>> Luckily, 320 < 030200 < 30200 so the ordering is not broken.
>>
>> Sorry for the mistake.
>>
>
> I think at least a comment somewhere is required too, probably in
> version.h, describing which versions were affected by this octal problem.
>
> rob

Added.

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0225.2-Remove-leading-zero-from-IPA_NUM_VERSION.patch
Type: text/x-patch
Size: 2291 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130513/cc59266e/attachment.bin>


More information about the Freeipa-devel mailing list