[Freeipa-devel] [PATCH] 0027 Prompt for nameserver IP address in dnszone-add

[Ana Krivokapic]

On 05/14/2013 12:05 PM, Ana Krivokapic wrote:
> On 05/13/2013 02:50 PM, Petr Vobornik wrote:
>> On 05/12/2013 03:10 PM, Ana Krivokapic wrote:
>>> On 05/10/2013 10:37 PM, Endi Sukma Dewata wrote:
>>>> On 5/10/2013 9:38 AM, Petr Viktorin wrote:
>>>>> On 05/10/2013 03:57 PM, Ana Krivokapic wrote:
>>>>> [...]
>>>>>> Thanks for catching the bugs. Updated patches are attached.
>>>>> Thanks! It works nicely.
>>>>> Endi is doing a quick check of the Javascript, if he doesn't find an
>>>>> issue then ACK.
>>>>>
>>>>> If this still makes it into 3.2.0, please only push the first patch
>>>>> there.
>>>> I tried this in the UI:
>>>>
>>>>    Zone name: test.com
>>>>    Authoritative nameserver: ns.sometest.com.
>>>>
>>>> The 'Nameserver IP address' field is still enabled. This is because
>>>> the name
>>>> server is considered in the zone although it's actually not.
>>>>
>>>> The CLI seems to work fine, it didn't ask for IP address.
>>>>
>>>> The UI probably could be fixed using endsWith(ns, '.' + zone).
>>>> Everything else
>>>> looks fine. ACK with the fix.
>>>>
>>> Fixed, updated patch attached.
>>>
>> A nitpick for UI part which is not a blocker(nack) because we don't
>> have any strict rules for following topic:
>>
>> We should avoid depending on widget's html output outside of the
>> widget code.
>>
>> So we should use:
>>    zone_w.save()[0]
>> instead of:
>>   $('input', zone_w.container).val();
>>
>> same for `ns`.
> Thanks, fixed.
>> Unfortunately there is no text_widget.is_enabled() method  so
>> `zone_w.input.prop('disabled')` can't be replaced.
> I implemented the `text_widget.is_enabled()` method, and replaced
> `zone_w.input.prop('disabled')` with `!zone_w.is_enabled()`.
>
> Updated patch attached.

Petr caught another bug: due to the return value of
`text_widget.save()`, an exception was raised in the case of empty zone.
This has been fixed in the attached patch.

I also changed the name of the endsWith() function to ends_with(), to
conform to our coding standard.

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akrivoka-0027-07-Prompt-for-nameserver-IP-address-in-dnszone-add.patch
Type: text/x-patch
Size: 9910 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130514/9cc569ce/attachment.bin>