[Freeipa-devel] [PATCH] 225 Remove leading zero from IPA_NUM_VERSION

[Martin Kosek]

On 05/14/2013 06:50 PM, Martin Kosek wrote:
> On 05/13/2013 03:40 PM, Petr Viktorin wrote:
>> On 05/13/2013 02:58 PM, Rob Crittenden wrote:
>>> Petr Viktorin wrote:
>>>> Due to my mistake in commit 9125285, the IPA_NUM_VERSION variable
>>>> contained a leading zero, so it was treated as octal in Python code.
>>>> Bumping the development version to 3.2.99 resulted in 030299, an invalid
>>>> value.
>>>> Luckily, 320 < 030200 < 30200 so the ordering is not broken.
>>>>
>>>> Sorry for the mistake.
>>>>
>>>
>>> I think at least a comment somewhere is required too, probably in
>>> version.h, describing which versions were affected by this octal problem.
>>>
>>> rob
>>
>> Added.
>>
> 
> This helps, thanks. ACK, pushed to master, ipa-3-1.
> 
> Martin

Rob also pushed the patch to ipa-3-2 (which I forgot) - thanks.

Martin