[Freeipa-devel] [PATCH] 0027 Prompt for nameserver IP address in dnszone-add

[Martin Kosek]

On 05/14/2013 04:24 PM, Petr Vobornik wrote:
> On 05/14/2013 01:36 PM, Ana Krivokapic wrote:
>> On 05/14/2013 12:05 PM, Ana Krivokapic wrote:
>>> On 05/13/2013 02:50 PM, Petr Vobornik wrote:
>>>> A nitpick for UI part which is not a blocker(nack) because we don't
>>>> have any strict rules for following topic:
>>>>
>>>> We should avoid depending on widget's html output outside of the
>>>> widget code.
>>>>
>>>> So we should use:
>>>>     zone_w.save()[0]
>>>> instead of:
>>>>    $('input', zone_w.container).val();
>>>>
>>>> same for `ns`.
>>> Thanks, fixed.
>>>> Unfortunately there is no text_widget.is_enabled() method  so
>>>> `zone_w.input.prop('disabled')` can't be replaced.
>>> I implemented the `text_widget.is_enabled()` method, and replaced
>>> `zone_w.input.prop('disabled')` with `!zone_w.is_enabled()`.
>>>
>>> Updated patch attached.
>>
>> Petr caught another bug: due to the return value of
>> `text_widget.save()`, an exception was raised in the case of empty zone.
>> This has been fixed in the attached patch.
>>
>> I also changed the name of the endsWith() function to ends_with(), to
>> conform to our coding standard.
>>
> 
> ACK
> 

Pushed to master, ipa-3-2.

Thanks!
Martin