[Freeipa-devel] [PATCH 0057] Do not allow removal of ID range of an active trust

[Tomas Babej]

On 05/27/2013 10:03 AM, Tomas Babej wrote:
> On 05/26/2013 08:56 PM, Alexander Bokovoy wrote:
>> On Fri, 24 May 2013, Tomas Babej wrote:
>>> On 05/20/2013 04:29 PM, Alexander Bokovoy wrote:
>>>> On Mon, 20 May 2013, Tomas Babej wrote:
>>>>> On 05/16/2013 11:16 AM, Ana Krivokapic wrote:
>>>>>> On 05/15/2013 03:41 PM, Tomas Babej wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> When removing an ID range using idrange-del command, validation
>>>>>>> in pre_callback ensures that the range does not belong to any
>>>>>>> active trust. In such case, ValidationError is raised.
>>>>>>>
>>>>>>> https://fedorahosted.org/freeipa/ticket/3615
>>>>>>>
>>>>>>> Tomas
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Freeipa-devel mailing list
>>>>>>> Freeipa-devel at redhat.com
>>>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>>
>>>>>> I suggest adding some unit tests to cover this change in 
>>>>>> functionality.
>>>>>>
>>>>>> -- 
>>>>>> Regards,
>>>>>>
>>>>>> Ana Krivokapic
>>>>>> Associate Software Engineer
>>>>>> FreeIPA team
>>>>>> Red Hat Inc.
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Freeipa-devel mailing list
>>>>>> Freeipa-devel at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>
>>>>> I incorporated the unit tests. It had to use direct access to LDAP 
>>>>> using ldapmodify since we need to create a mock AD trusted range 
>>>>> first.
>>>>>
>>>>> Tomas
>>>>
>>> We got rid of openldap utilities now. While using python.ldap 
>>> module, I also made the tests much more robust and added a new test 
>>> case.
>> In general patches look fine, there is one small nitpick.
>> I'll run tests on Monday and then will provide final ACK.
>>
>>> --- a/tests/test_xmlrpc/test_range_plugin.py
>>> +++ b/tests/test_xmlrpc/test_range_plugin.py
>>> @@ -22,66 +22,171 @@ Test the `ipalib/plugins/idrange.py` module, 
>>> and XML-RPC in general.
>>> """
>>>
>>> from ipalib import api, errors, _
>>> +from ipapython.ipautil import run
>> This import is unused, can be removed.
>>
> Fixed, thanks for catching that.
>
> Updated patch attached.
>
> Tomas
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
Additionally, I removed one redundant variable upon further review.

Tomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130527/ff78b45e/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0057-5-Do-not-allow-removal-of-ID-range-of-an-active-trust.patch
Type: text/x-patch
Size: 8636 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130527/ff78b45e/attachment.bin>