[Freeipa-devel] [PATCHES] 0270-0271 Support for Pylint 1.0

[Alexander Bokovoy]

On Wed, 04 Sep 2013, Petr Viktorin wrote:
> On 08/19/2013 12:29 PM, Petr Viktorin wrote:
>> Hello,
>> The first patch fixes a minor problem that Pylint 1.0 finds in our code.
>> 
>> The second patch makes make-lint compatible with Pylint 1.0. It contains
>> a workaround for a Pylint bug; before pushing this we should wait for a
>> while to see if a fixed Pylint is released.
>> 
> 
> A fixed version of Pylint was released, bug workarounds are no 
> longer necessary.
> 
> Updated patches attached.
> 
> https://fedorahosted.org/freeipa/ticket/3865
I tried the patches and still see an error on up to date Fedora 19
(including updates-testing):

./make-lint 
Traceback (most recent call last):
   File "./make-lint", line 272, in <module>
     sys.exit(main())
   File "./make-lint", line 243, in main
     linter.check(files)
   File "/usr/lib/python2.7/site-packages/pylint/lint.py", line 599, in check
     self.check_astroid_module(astroid, walker, rawcheckers, tokencheckers)
   File "/usr/lib/python2.7/site-packages/pylint/lint.py", line 685, in check_astroid_module
     walker.walk(astroid)
   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 662, in walk
     self.walk(child)
   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 662, in walk
     self.walk(child)
   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 662, in walk
     self.walk(child)
   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 662, in walk
     self.walk(child)
   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 662, in walk
     self.walk(child)
   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 662, in walk
     self.walk(child)
   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 659, in walk
     cb(astroid)
   File "./make-lint", line 126, in visit_getattr
     ignored = self._find_ignored_attrs(owner)
   File "./make-lint", line 110, in _find_ignored_attrs
     for klass in self._related_classes(owner):
   File "./make-lint", line 102, in _related_classes
     for base in klass.ancestors():
   File "/usr/lib/python2.7/site-packages/astroid/scoped_nodes.py", line 810, in ancestors
     for grandpa in baseobj.ancestors(True, context):
   File "/usr/lib/python2.7/site-packages/astroid/scoped_nodes.py", line 801, in ancestors
     for baseobj in stmt.infer(context):
TypeError: unbound method infer() must be called with Tuple instance as
first argument (got InferenceContext instance instead)


At this point I'm not sure whether it is astroid's issue or ours...
Astroid did change from 0.24 to 1.0 on August 13th in Fedora (even in
Fedora 19 where version updates after release are generally
discouraged, especially in case of ABI change).



-- 
/ Alexander Bokovoy