[Freeipa-devel] [PATCHES] 0177-0179 Add missing dict methods to CIDict

[Jan Cholasta]

On 20.2.2013 17:37, Petr Viktorin wrote:
> On 02/19/2013 01:51 PM, Jan Cholasta wrote:
>> Hi,
>>
>> On 5.2.2013 18:02, Petr Viktorin wrote:
>>> CIDict, our case-insensitive dictionary, inherits from dict but did not
>>> reimplement the full dict interface. Calling the missing methods
>>> silently invoked case-sensitive behavior. Our code seems to avoid that,
>>> but it's a bit of a minefield for new development.
>>>
>>> Patch 119 adds the missing dict methods (except
>>> view{items,keys,values}(), which now raise errors), and adds tests.
>>
>> Can you please also add the (obj, **kwargs) and (**kwargs) variants of
>> __init__ and update?
>
> Added, thanks for the catch.
>
>>
>>>
>>>
>>> Patches 117-118 modernize the testsuite a bit (these have been sitting
>>> in my queue for a while, I think now is a good time to submit them):
>>> The first one moves some old tests from the main code tree to tests/.
>>> (The adtrust_install test wasn't run before, this move makes nose notice
>>> it).
>>> The second converts CIDict's unittest-based suite to nose.
>>>
>>
>> Honza
>>
>
>

Whoa, I totally forgot about these patches!

Can you please rebase them?

One more comment:

   Document that CIDict.copy() returns a plain dict.

Why does it return a plain dict? I think it should return a CIDict, 
otherwise it is not actually a copy, right?

Honza

-- 
Jan Cholasta