[Freeipa-devel] [PATCHES] 0282-0286 Test improvements

Petr Viktorin pviktori at redhat.com
Tue Sep 24 15:42:34 UTC 2013


Hello,
These patches fix issues in the test suite, mainly those in BeakerLib 
integration.


Patch 0282:
When requested logs don't exist, tests shouldn't fail. The BeakerLib 
plugin was too strict here.

Patch 0283:
The Ordered plugin does not play well with generators: the generated 
tests are run, but they're not reported plugins' hooks (startTest etc.).
I spent some time looking for ways to correct this, but was unsuccessful.
The patch disables ordering for test generators (relative to the methods 
of a class -- the tests from one generator still run in the generated 
order).
With this the BeakerLib plugin will report generated tests.

Patch 0284:
This adds arguments to "test names" that the BeakerLib plugin gives to 
generated tests.
The patch only adds the names to the integration tests. As it becomes 
possible to run the rest of the suite out-of-tree, I can add them to the 
other test generators as well.

Patch 0285:
This just adds logging to Host.ldap_connect.

Patch 0285:
Correct the CLITestContext context manager used in help tests to 
re-raise unexpected exceptions.


Except 0283/0284, these can be reviewed/applied individually.

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0282-ipatests.beakerlib_plugin-Warn-instead-of-failing-wh.patch
Type: text/x-patch
Size: 1101 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130924/4adff593/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0283-ipatests.order_plugin-Exclude-test-generators-from-t.patch
Type: text/x-patch
Size: 2107 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130924/4adff593/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0284-ipatests.beakerlib_plugin-Add-argument-of-generated-.patch
Type: text/x-patch
Size: 2395 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130924/4adff593/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0285-ipatests.test_integration.host-Add-logging-to-ldap_c.patch
Type: text/x-patch
Size: 1174 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130924/4adff593/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0286-ipatests.test_cmdline.test_help-Re-raise-unexpected-.patch
Type: text/x-patch
Size: 1167 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130924/4adff593/attachment-0004.bin>


More information about the Freeipa-devel mailing list