[Freeipa-devel] [PATCH 0015] Add support for managing user auth types

[Nathaniel McCallum]

On Mon, 2013-09-23 at 15:19 +0200, Petr Viktorin wrote:
> Great, we're getting close!
> 
> Please send patches in `git format-patch` style (they include commit info).

I usually do, I don't know what happened this last time. Sorry! :)

> Also, please bump the API revision in VERSION since API.txt was changed.

Fixed.

> When adding the objectclass in user, it is possible that the user 
> doesn't exist. You should call handle_not_found in this case so the 
> appropriate error message is generated.
> I ended up doing this for testing, squash in the patch if you want.

Fixed.

> There's another test failure when trying to rename a manager user. I 
> didn't investigate in detail why that happens.

Does the failure happen without the patch? Is this just a standard make
check?

> I'm attaching the tests I used, do they look OK?

Looks great!

Nathaniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-npmccallum-0015-4-Add-support-for-managing-user-auth-types.patch
Type: text/x-patch
Size: 11612 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130925/afc03195/attachment.bin>