[Freeipa-devel] [PATCH 0113] ipa-client: Set NIS domain name in the installer

[Jan Cholasta]

On 26.9.2013 14:38, Martin Kosek wrote:
> On 09/26/2013 02:28 PM, Tomas Babej wrote:
>> On 09/26/2013 12:20 PM, Jan Cholasta wrote:
>>> On 26.9.2013 10:28, Tomas Babej wrote:
>>>> Hi,
>>>>
>>>> Provides two new options for the ipa-client-install:
>>>>       --nisdomain: specifies the NIS domain name
>>>>       --no_nisdomain: flag to aviod setting the NIS domain name
>>>>
>>>> In case no --nisdomain is specified and --no_nisdomain flag was
>>>> not set, the IPA domain is used.
>>>>
>>>> Manual pages updated.
>>>>
>>>> http://fedorahosted.org/freeipa/ticket/3202
>>>>
>>>> Design page:
>>>>
>>>> http://www.freeipa.org/page/V3_Minor_Enhancements
>>>>
>>>
>>> Is the --no-nisdomain option necessary? IMO --nisdomain with empty value
>>> (i.e. "--nisdomain=" or "--nisdomain ''") should be sufficient for this.
>>>
>>> Honza
>>>
>>
>> I just found --no-nisdomain more descriptive and explicit. If there is a
>> consensus, I can remove it.
>>
>
> I am not aware of any precedent that would warrant --nisdomain="".

I have seen concerns about the number of ipa-client-install options in 
the past (not by me).

>
> IMO --no-nisdomain is more consistent with rest of the options.

I don't see any other --<option>=<value> and --no-<option> option pair 
in ipa-client-install, so what consistency are you talking about?

-- 
Jan Cholasta