[Freeipa-devel] [PATCH 0018] Ensure credentials structure is initialized

Petr Viktorin pviktori at redhat.com
Fri Sep 27 10:49:48 UTC 2013


On 09/26/2013 04:48 PM, Nathaniel McCallum wrote:
> On Thu, 2013-09-26 at 12:36 +0200, Petr Viktorin wrote:
>> On 09/26/2013 12:07 AM, Nathaniel McCallum wrote:
>>> Patch attached.
>>>
>>
>> There's a ticket to make FreeIPA build with stricter warnings:
>> https://fedorahosted.org/freeipa/ticket/3896
>>
>> AFAIU this will trip -Wmissing-field-initializers.
>
> C89 (implicitly) and C99 (explicitly) define that unspecified fields in
> initializers have the same initialization as static storage (aka zero).
> This feature is both well defined and useful. We should disable that
> warning.

I added a note to that ticket, warnings can be discussed there. We'll 
probably want to coordinate with SSSD as their team has more C experience.

Back to your patch:
Does the issue have a ticket in Trac? Which branches does it apply to?

-- 
Petr³




More information about the Freeipa-devel mailing list