[Freeipa-devel] [PATCH][RFC] 9 CA-less tests generate failure

Martin Kosek mkosek at redhat.com
Tue Apr 8 12:14:18 UTC 2014


On 04/04/2014 10:59 AM, Misnyovszki Adam wrote:
> Hi,
> 
> CA-less test suite always generate failures when installing revoked
> certificates. This is a known issue, described in
> https://fedorahosted.org/freeipa/ticket/4270 , this fix skips these
> tests, outputting a notification message for the ticket.
> Now it outputs this:
> 
> [amisnyov at host freeipa]$ ./make-test
> ipatests/test_integration/test_caless.py:TestServerInstall.test_revoked_http                                                                                                                    
> /usr/bin/nosetests -v --with-doctest --doctest-tests --exclude=plugins
> ipatests/test_integration/test_caless.py:TestServerInstall.test_revoked_http
> IPA server install with revoked HTTP certificate ... SKIP: Known
> CA-less installation defect, see
> https://fedorahosted.org/freeipa/ticket/4270
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1020.253s
> 
> OK (SKIP=1)
> ======================================================================
> passed under '/usr/bin/python2.7'
> 
> ** pass **
> 
> 
> https://fedorahosted.org/freeipa/ticket/4271
> 
> There could be another possible solution, I could write a nose plugin to
> enable raising warnings instead of skipping a test. This could be
> achieved by adding a @unittest.expectedFailure for a specific test, so
> if it fails, it counts as an error/warning. There is a poc in a nose
> ticket located in
> http://code.google.com/p/python-nose/issues/detail?id=428 , not sure
> how much time it takes to implement it as a plugin, or is it even
> worth, because if this is implemented, we could also use this feature
> when eg. DNS is not configured, this is why RFC.
> 
> Thanks
> Adam

Thanks for question. I personally think this solution is good enough for now.
We may even chose to switch to pytest in the future, so I would not invest too
much in python-nose specific plugins at this point.

ACK. Pushed to master, ipa-3-3.

Martin




More information about the Freeipa-devel mailing list