[Freeipa-devel] [PATCH][RFC] 7 automember rebuild nowait feature added

[Misnyovszki Adam]

On Mon, 07 Apr 2014 09:43:10 +0200
Petr Viktorin <pviktori at redhat.com> wrote:

> On 03/27/2014 03:37 PM, Misnyovszki Adam wrote:
> > On Wed, 26 Mar 2014 13:15:55 +0100
> > Petr Viktorin <pviktori at redhat.com> wrote:
> [...]
> >>
> >> Looks great! I'm just concerned about the error returned when the
> >> task takes too long:
> >>       $ ipa automember-rebuild --type group
> >>       ipa: ERROR: LDAP timeout
> >> I don't think it's sufficiently clear from this that waiting for
> >> the task timed out, but the task was actually started
> >> successfully. A custom error with a more descriptive message would
> >> be useful.
> >>
> >>
> >> Also I've noticed that the "nstaskstatus" of a successful task is:
> >>       Automember rebuild task finished. Processed (1) entries.
> >> This looks helpful; we could return it as the summary.
> >>
> >
> > Hi,
> > both fixed.
> > Greets
> > Adam
> >
> 
> Sorry for the delay!
> 'Automember' is a translatable string, so please wrap it in _() when 
> raising TaskTimeout. Also please update the tests.
> Otherwise with a little rebase it's good to go.
> 
> 

Hi,
see the attached modifications, tests corrected, and added for no-wait,
also rebased for current master.
Greets
Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-amisnyov-0007-7-automember-rebuild-nowait-feature-added.patch
Type: text/x-patch
Size: 11989 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140408/bfd6bab0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-amisnyov-0008-2-plugin-registration-refactoring-for-automembership.patch
Type: text/x-patch
Size: 4956 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140408/bfd6bab0/attachment-0001.bin>