[Freeipa-devel] [PATCH 0234] Prevent NULL dereference before sync_concurr_limit_signal() calls

[Tomas Hozza]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/09/2014 02:07 PM, Petr Spacek wrote:
> Hello,
> 
> Prevent NULL dereference before sync_concurr_limit_signal() calls.
> 
> Missing check was causing NULL dereference in case where
> manager_get_ldap_instance() failed. This typically happens when BIND
> is processing LDAP updates during shutdown.
> 
> I noticed this crash during sanity testing 4.2 release...
> 
> Please review it ASAP so I can release 4.3.
> 
> How to reproduce the problem:
> Run BIND manually from console:
> $ named -4 -g -u named -m record -n 10
> and press Ctrl+C "almost immediately".
> 
> Sometimes it shutdowns cleanly and sometimes you can see a crash:
> 
> Thank you for your time!
> 

ACK.

I'm not able to reproduce the issue, but the patch looks reasonable and
should not break anything.

Regards,

Tomas Hozza
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTRUklAAoJEMWIetUdnzwtSSoH/0ZIz+MZfZ1O9JH5kGvJQKQo
3s1Fqeh601ReRKGnFu+nBt5hXzGzDOjsXM0x8bJH5r1cABn9XzYjupVQg0FjziM1
XIoJaDRB8L09sjLefjPoY87x0K6OsEQ/EmipDZPQB62MPpWJdGkJi6u2ug2gguRN
fEdMeFdvm6T8faU/POd1D/1mEky2DqzNXViLf+6Pdi03b6lvUzoOvqsLwh4+Npvw
NVUw7+SzwylCJQBcmZShCL6XRnaN4Qe9LCUG997HNwF/n3K1NjUgbwVqqmdLPGXh
XAtcQxic5TQkKl2A1+52YFLMLSLY5gfAg/qBYmT1BQM+IuUIUYOe7fXL0fxr+A0=
=TNAe
-----END PGP SIGNATURE-----