[Freeipa-devel] [PATCH] 11 - CI - test_forced_client_reenrollment stability fix

[Martin Kosek]

On 04/15/2014 05:36 PM, Misnyovszki Adam wrote:
> On Tue, 15 Apr 2014 12:51:47 +0200
> Petr Viktorin <pviktori at redhat.com> wrote:
>
>> On 04/15/2014 12:41 PM, Misnyovszki Adam wrote:
>>> Hi,
>>> this patch fixes FreeIPA Jenkins CI test
>>> freeipa-integration-forced_client_reenrollment-f19, by turning sshfp
>>> records into a set, and sorting them before assertion.
>>>
>>> https://fedorahosted.org/freeipa/ticket/4298
>>>
>>> Greets
>>> Adam
>>
>> The list.sort() method sorts in-place and returns None, so now the
>> test would not really test anything. Use the sorted() function.
>>
>> You might want to log the value before returning it.
>>
>
> My mistake, see the attached, corrected patch.
> Thanks
> Adam

Adam, Petr - why can't we use a set as I already proposed in the ticket 
description?

 >>> set(['i', 'p', 'a']) == set(['a', 'p', 'i'])
True

Martin