[Freeipa-devel] [PATCH] 11 - CI - test_forced_client_reenrollment stability fix

[Misnyovszki Adam]

On Wed, 16 Apr 2014 07:59:39 +0200
Martin Kosek <mkosek at redhat.com> wrote:

> On 04/15/2014 05:36 PM, Misnyovszki Adam wrote:
> > On Tue, 15 Apr 2014 12:51:47 +0200
> > Petr Viktorin <pviktori at redhat.com> wrote:
> >
> >> On 04/15/2014 12:41 PM, Misnyovszki Adam wrote:
> >>> Hi,
> >>> this patch fixes FreeIPA Jenkins CI test
> >>> freeipa-integration-forced_client_reenrollment-f19, by turning
> >>> sshfp records into a set, and sorting them before assertion.
> >>>
> >>> https://fedorahosted.org/freeipa/ticket/4298
> >>>
> >>> Greets
> >>> Adam
> >>
> >> The list.sort() method sorts in-place and returns None, so now the
> >> test would not really test anything. Use the sorted() function.
> >>
> >> You might want to log the value before returning it.
> >>
> >
> > My mistake, see the attached, corrected patch.
> > Thanks
> > Adam
> 
> Adam, Petr - why can't we use a set as I already proposed in the
> ticket description?
> 
>  >>> set(['i', 'p', 'a']) == set(['a', 'p', 'i'])
> True
> 
> Martin

Hi,
see the attached patch.
Thanks
Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-amisnyov-0011-3-CI-test_forced_client_reenrollment-stability-fix.patch
Type: text/x-patch
Size: 1250 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140416/b053a0ad/attachment.bin>