[Freeipa-devel] Ipatests fixes

[Petr Viktorin]

On 04/17/2014 12:22 PM, Tomas Babej wrote:
> On 04/09/2014 01:33 PM, Petr Viktorin wrote:
>> On 04/09/2014 12:07 PM, Tomas Babej wrote:
>>> Hi,
>>>
>>> the following batch deals with the following:
>>>
>>> * cleans up apache's semaphores prior to installing IPA (CA install can
>>> get stuck when IPA is reinstalled many times)
>>
>> What happens if Apache is running for some reason? Should we also stop
>> it before deleting the semaphores?
>
> Agreed, if for any reason apache is running, we should stop it
> beforehand. Fixed.
>
>>
>>> * allows to pass extra arguments to install_client task
>>
>> Please avoid mutable argument defaults; use `extra_args=()` and then
>> `list(extra_args)`
>
> Fixed.
>
>>
>>> * uses trailing dot in the hostname as fqdn which should not be
>>> overridden by domain name
>>
>> ACK.
>>
>>> * fixes incorrect assert for UIDs/GIDs in legacy client tests
>>
>> ACK, this fixes a lot of failures (though not all of them yet).
>>
>
> Updated patches attached.
>

ACK, pushed to:
master: f74ab3cba2b02e4726519e602f7de4fc86fca2d1
ipa-3-3: be8f4768877168720d051ba94c3e908af67f1306


-- 
Petr³