[Freeipa-devel] [PATCH 177] ipatests: Extend test suite for ID ranges

[Martin Kosek]

On 04/22/2014 12:53 PM, Tomas Babej wrote:
> Hi,
> 
> Add tests coverage for recently added ID range checks dependant
> on the ID range types.
> 
> Part of: https://fedorahosted.org/freeipa/ticket/4137
> 
> 
> 

NACK:

======================================================================
FAIL: test_range[21]: idrange_del: Delete non-active AD trusted range
u'domain1range1'
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/root/freeipa-master/ipatests/test_xmlrpc/xmlrpc_test.py", line 301, in
<lambda>
    func = lambda: self.check(nice, **test)
  File "/root/freeipa-master/ipatests/test_xmlrpc/xmlrpc_test.py", line 319, in
check
    self.check_output(nice, cmd, args, options, expected, extra_check)
  File "/root/freeipa-master/ipatests/test_xmlrpc/xmlrpc_test.py", line 359, in
check_output
    assert_deepequal(expected, got, nice)
  File "/root/freeipa-master/ipatests/util.py", line 344, in assert_deepequal
    assert_deepequal(e_sub, g_sub, doc, stack + (key,))
  File "/root/freeipa-master/ipatests/util.py", line 344, in assert_deepequal
    assert_deepequal(e_sub, g_sub, doc, stack + (key,))
  File "/root/freeipa-master/ipatests/util.py", line 316, in assert_deepequal
    TYPE % (doc, type(expected), type(got), expected, got, stack)
AssertionError: assert_deepequal: type(expected) is not type(got).
  test_range[21]: idrange_del: Delete non-active AD trusted range u'domain1range1'
  type(expected) = <type 'unicode'>
  type(got) = <type 'list'>
  expected = u''
  got = []
  path = ('result', 'failed')