[Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

[Martin Kosek]

On 04/23/2014 12:50 PM, Tomas Babej wrote:
> 
> On 04/22/2014 12:50 PM, Tomas Babej wrote:
>> On 04/17/2014 02:44 PM, Alexander Bokovoy wrote:
>>> You replace this by
>>>      range->base_rid_set = (slapi_entry_attr_find(entry, IPA_BASE_RID,
>> &attr) == -1);
>>
>> You probably meant "== 0". Fixed.
>>
>>> I know that is was in your original code, but can we get numbers
>>> replaced by an enum? I'd prefer to see symbolic names used instead of
>>> numbers.
>> Fixed in a separate patch 0178 (attached).
>>
>>> Please expand the message here, may be something like
>>>  LOG("Empty forest root map as trusts are not enabled on this IPA
>> server\n");
>>
>> Fixed.
>>
>> Updated patchset attached.
>>
>> Tomas
> 
> I amended the commit message in the patch 178, whole patchset attached.

I verified and tested that you addressed all Alexander's findings, it's ok -
pushed 172-176 to master.

I reviewed 178-2 and it is OK, it indeed improves readibility. ACK and pushed
to master.

Martin