[Freeipa-devel] [PATCH 0017] Add wait_for_dns option to default.conf

[Martin Kosek]

On 04/04/2014 02:11 PM, Petr Viktorin wrote:
> On 04/04/2014 01:50 PM, Martin Kosek wrote:
>> On 04/04/2014 11:57 AM, Petr Viktorin wrote:
>>> On 04/02/2014 02:38 PM, Petr Spacek wrote:
>>>> On 2.4.2014 14:36, Petr Spacek wrote:
>>>>> Hello,
>>>>>
>>>>> Add wait_for_dns option to default.conf.
>>>>>
>>>>> This option makes record changes in DNS tree synchronous.
>>>>> IPA calls will wait until new data are visible over DNS protocol
>>>>> or until timeout.
>>>>>
>>>>> It is intended only for testing. It should prevent tests from
>>>>> failing if there is bigger delay between changes in LDAP and DNS.
>>>>>
>>>>> My personal recommendation is to use value "5" (for testing!).
>>>>
>>>> Ah, my hands were faster than head :-)
>>>>
>>>> This patch was supersedes patch my patch 0015 and should apply to
>>>> vanilla master (at the moment).
>>>
>>> Looks good to me.
>>> ACK, pushed to master: 34fc447c00189d53ccf44184cfd5ed48cde6bf86
>>>
>>>
>>
>> Petr, can we now enable wait_for_dns for our tests then? Hopefully it will
>> solve the unit test failures we saw.
>>
>> Martin
>>
> 
> Here it is:
> https://github.com/encukou/freeipa-ci/commit/d36aa4fb54e4b56c040ecbe886a1156c18863023
> 
> I generally wait for a successful build before pushing to the ci config repo.

Ok - ACK :)

Martin