[Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

[Martin Kosek]

On 04/03/2014 04:31 PM, Alexander Bokovoy wrote:
> On Wed, 02 Apr 2014, Martin Kosek wrote:
>> On 04/01/2014 12:03 PM, Jan Pazdziora wrote:
>>> On Tue, Apr 01, 2014 at 10:05:39AM +0200, Tomas Babej wrote:
>>>>
>>>>> Yes, that was the intention. Mistake on my part, I'll send updated patches.
>>>>>
>>>>
>>>> Updated patch attached.
>>>
>>> Ack based on reading the code and documentation for
>>> slapi_ch_free_string.
>>>
>>
>> Ok, thanks. Though I would like this patch to be also functionally tested that
>> it does not break anything, ideally together with your other ipa-range patches.
> ACK to 0162, 0161, 0158 (should be applied in this order).
> 
> # ipa idrange-find
> ----------------
> 2 ranges matched
> ----------------
> Range name: AD.TEST_id_range
> First Posix ID of the range: 1115000000
> Number of IDs in the range: 200000
> First RID of the corresponding RID range: 0
> Domain SID of the trusted domain:  S-1-5-21-2275361654-3393353068-3720134936
> Range type: Active Directory domain range
> 
> Range name: T.VDA.LI_id_range
> First Posix ID of the range: 917400000
> Number of IDs in the range: 200000
> First RID of the corresponding RID range: 1000
> First RID of the secondary RID range: 100000000
> Range type: local domain range
> ----------------------------
> Number of entries returned 2
> ----------------------------
> # ipa idrange-add AD.TEST_1_id_range
> First Posix ID of the range: 1119000000
> Number of IDs in the range: 200000
> First RID of the corresponding RID range: 0
> First RID of the secondary RID range: 1000000
> ipa: ERROR: Constraint violation: New primary rid range overlaps with existing
> primary rid range.
> 
> the message comes from the ipa-range-check plugin.
> 
> 

Pushed all 3 to master.

Martin