[Freeipa-devel] Ipatests fixes

Petr Viktorin pviktori at redhat.com
Wed Apr 9 11:33:09 UTC 2014


On 04/09/2014 12:07 PM, Tomas Babej wrote:
> Hi,
>
> the following batch deals with the following:
>
> * cleans up apache's semaphores prior to installing IPA (CA install can
> get stuck when IPA is reinstalled many times)

What happens if Apache is running for some reason? Should we also stop 
it before deleting the semaphores?

> * allows to pass extra arguments to install_client task

Please avoid mutable argument defaults; use `extra_args=()` and then 
`list(extra_args)`

> * uses trailing dot in the hostname as fqdn which should not be
> overridden by domain name

ACK.

> * fixes incorrect assert for UIDs/GIDs in legacy client tests

ACK, this fixes a lot of failures (though not all of them yet).

-- 
Petr³




More information about the Freeipa-devel mailing list