[Freeipa-devel] Ipatests fixes

[Tomas Babej]

On 04/09/2014 01:33 PM, Petr Viktorin wrote:
> On 04/09/2014 12:07 PM, Tomas Babej wrote:
>> Hi,
>>
>> the following batch deals with the following:
>>
>> * cleans up apache's semaphores prior to installing IPA (CA install can
>> get stuck when IPA is reinstalled many times)
>
> What happens if Apache is running for some reason? Should we also stop
> it before deleting the semaphores?

Agreed, if for any reason apache is running, we should stop it
beforehand. Fixed.

>
>> * allows to pass extra arguments to install_client task
>
> Please avoid mutable argument defaults; use `extra_args=()` and then
> `list(extra_args)`

Fixed.

>
>> * uses trailing dot in the hostname as fqdn which should not be
>> overridden by domain name
>
> ACK.
>
>> * fixes incorrect assert for UIDs/GIDs in legacy client tests
>
> ACK, this fixes a lot of failures (though not all of them yet).
>

Updated patches attached.

-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0168-2-ipatests-Fix-apache-semaphores-prior-to-installing-I.patch
Type: text/x-patch
Size: 1848 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140417/a15a3f88/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0169-2-ipatests-tasks-Accept-extra-arguments-when-installin.patch
Type: text/x-patch
Size: 1303 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140417/a15a3f88/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0170-ipatests-Allow-using-FQDN-with-trailing-dot-as-final.patch
Type: text/x-patch
Size: 1548 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140417/a15a3f88/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0171-ipatests-Fix-incorrect-UID-GID-reference-for-subdoma.patch
Type: text/x-patch
Size: 2294 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140417/a15a3f88/attachment-0003.bin>