[Freeipa-devel] [PATCHES] 255-259 Framework tweaks

[Petr Viktorin]

On 04/18/2014 10:57 AM, Jan Cholasta wrote:
> On 17.4.2014 16:58, Petr Viktorin wrote:
>> On 04/17/2014 02:33 PM, Tomas Babej wrote:
>>> ACK for 256 - 259.
>>>
>>> On 04/01/2014 10:45 AM, Jan Cholasta wrote:
>>>> Hi,
>>>>
>>>> while working with Martin Bašti on issues in his dns plugin patches we
>>>> ran into several limitations in the framework. The attached patches
>>>> remove these limitations.
>>>>
>>>> Also, Tomáš Babej pointed out that when using --raw, all the attribute
>>>> names should use letter casing as returned by python-ldap. Patch 259
>>>> implements that.
>>>>
>>>> See commit messages for details.
>>
>> Sorry for the delay.
>> There are some conflicts with master, could you please rebase?
>
> Yes.
>

Unfortunately, I get lots of test failures with these patches, like this 
one:

======================================================================
FAIL: test_hostgroup[13]: hostgroup_del: Delete u'testhostgroup1'
----------------------------------------------------------------------
Traceback (most recent call last):
   File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in 
runTest
     self.test(*self.arg)
   File "/home/pviktori/freeipa/ipatests/test_xmlrpc/xmlrpc_test.py", 
line 301, in <lambda>
     func = lambda: self.check(nice, **test)
   File "/home/pviktori/freeipa/ipatests/test_xmlrpc/xmlrpc_test.py", 
line 319, in check
     self.check_output(nice, cmd, args, options, expected, extra_check)
   File "/home/pviktori/freeipa/ipatests/test_xmlrpc/xmlrpc_test.py", 
line 359, in check_output
     assert_deepequal(expected, got, nice)
   File "/home/pviktori/freeipa/ipatests/util.py", line 344, in 
assert_deepequal
     assert_deepequal(e_sub, g_sub, doc, stack + (key,))
   File "/home/pviktori/freeipa/ipatests/util.py", line 344, in 
assert_deepequal
     assert_deepequal(e_sub, g_sub, doc, stack + (key,))
   File "/home/pviktori/freeipa/ipatests/util.py", line 316, in 
assert_deepequal
     TYPE % (doc, type(expected), type(got), expected, got, stack)
AssertionError: assert_deepequal: type(expected) is not type(got).
   test_hostgroup[13]: hostgroup_del: Delete u'testhostgroup1'
   type(expected) = <type 'list'>
   type(got) = <type 'unicode'>
   expected = []
   got = u''
   path = ('result', 'failed')


-- 
Petr³