[Freeipa-devel] [PATCHES] 0629-0630 test_integration.task: Add DNS A records when installing a master

[Martin Kosek]

On 08/04/2014 12:35 PM, Tomas Babej wrote:
> Functionally the patches look OK, tests are passing as well.
> 
> 629: ACK

Hmm. Does this line:

+                            '-e', 'wait_for_dns=30',

really do anything given the environmental variable is evaluated on the server
in the post callback? Wouldn't we rather need to update our installer to add
this to /etc/ipa/default.conf?

> 630: The only thing missing is the documentation of the new suboption in
> the ipa-test-task manpage.
> 
> When you add that, it's an ACK for both patches.
> 
> On 08/04/2014 12:21 PM, Petr Viktorin wrote:
>> Hello,
>> Here are some fixes to our integration tests.

Maybe I miss something, but it seems to me that option name
+        subparser.add_argument('--no-a-records', action='store_false',
and arg name
+        tasks.install_master(master, add_a_records=args.add_a_records)
do not match.

Martin