[Freeipa-devel] [PATCH 0101, 106] Tests: host plugin (Allow to add host if AAAA record exists)

[Martin Basti]

On 07/08/14 17:05, Martin Basti wrote:
> On 07/08/14 16:27, Petr Viktorin wrote:
>> On 08/07/2014 02:33 PM, Martin Basti wrote:
>>> On 28/07/14 14:11, Petr Viktorin wrote:
>>>> On 07/09/2014 06:29 PM, Martin Basti wrote:
>>>>> Patch attached.
>>>>> Ticket: https://fedorahosted.org/freeipa/ticket/4164
>>>>>
>>>>
>>>> Looks & works fine for me.
>>>> Can you also add a test for this?
>>>>
>>>>
>>> Tests attached.
>>> I also added tests with --ip-address parameter.
>>>
>>
>> This works, thanks!
>> I have some comments however:
>>
>> Variables like `name5` can have more descriptive names, so that you 
>> can look at the test definition and actually know what's being tested.
>>
>> Some of the tests are independent (both in the sense that they don't 
>> need the other tests to be run, and that they test a different thing 
>> than the others); those can be in separate classes.
>>
>>
>> There are better things to do in IPA than making the tests perfect, 
>> so ACK if you want to push this as is.
>>
> Please wait, I will fix the names then, it'll be fast.
>
Updated patch attached.

-- 
Martin Basti

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0106.2-Tests-host-tests-with-dns.patch
Type: text/x-patch
Size: 19243 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140807/0d6aba71/attachment.bin>