[Freeipa-devel] [PATCH 0173] Throw zonemgr error message before installation proceeds

[Jan Cholasta]

Dne 1.12.2014 v 09:10 Jan Cholasta napsal(a):
> Hi,
>
> Dne 27.11.2014 v 14:20 Martin Basti napsal(a):
>> Ticket: https://fedorahosted.org/freeipa/ticket/4771
>> Patch attached.
>
> I would prefer if you did something like this instead:
>
>   1) Add validate_idn_normalized function with the normalized IDN check
> to ipapython.dnsutil, have it raise ValueError if the check fails. (Also
> please get rid of the map() call for better readability.)
>
>   2) Use validate_idn_normalized in DNSNameParam.
>
>   3) Do the following in validate_zonemgr_str:
>
>      validate_idn_normalized(zonemgr)
>      try:
>          zonemgr = DNSName(zonemgr)
>      except dns.exception.DNSException as e:
>          raise ValueError(e)
>
> Honza
>

Actually, sratch that, exceptions thrown by python-dns do not have messages.

ACK.

Pushed to:
master: ca25c92ea89661755d7204ac703e8c419c8929fa
ipa-4-1: 07e29d250550f238e5706b348d69632fdbb67bda

Honza

-- 
Jan Cholasta