[Freeipa-devel] [PATCH 0036] Add missing python files to Makefile

[Gabe Alford]

Yeah. This is what I was talking about ipaclient builds still relying on
Makefile.am. Plus if you remove the ipaclient/Makefile.am and then run
`make rpm`, it fails to find the *.py files to package into the rpm.

Gabe

On Wed, Dec 3, 2014 at 6:05 AM, Martin Kosek <mkosek at redhat.com> wrote:

> On 12/03/2014 05:13 AM, Gabe Alford wrote:
> > This patch removes the changelog and Makefile.am for ipaclient as well.
> >
> > Thanks,
> >
> > Gabe
> >
> > On Mon, Dec 1, 2014 at 8:28 AM, Martin Kosek <mkosek at redhat.com> wrote:
> >
> >> On 12/01/2014 04:25 PM, Rob Crittenden wrote:
> >>> Gabe Alford wrote:
> >>>>
> >>>> On Mon, Dec 1, 2014 at 6:05 AM, Martin Kosek <mkosek at redhat.com
> >>>> <mailto:mkosek at redhat.com>> wrote:
> >>>>
> >>>>     On 11/30/2014 03:28 AM, Gabe Alford wrote:
> >>>>     > Ignore the last patch. Updated patch attached.
> >>>>     >
> >>>>     > On Sat, Nov 29, 2014 at 6:03 PM, Gabe Alford
> >>>>     <redhatrises at gmail.com <mailto:redhatrises at gmail.com>> wrote:
> >>>>     >
> >>>>     >> This patch removes the app_PYTHON usage.
> >>>>     >>
> >>>>     >> Thanks,
> >>>>     >>
> >>>>     >> Gabe
> >>>>     >>
> >>>>     >> On Thu, Nov 27, 2014 at 9:40 AM, Martin Kosek <
> mkosek at redhat.com
> >>>>     <mailto:mkosek at redhat.com>> wrote:
> >>>>     >>
> >>>>     >>> Exactly, this was the message from Martin :-) I did not test
> it
> >>>>     myself,
> >>>>     >>> but
> >>>>     >>> removing all app_PYTHON should be benign given we use Python
> >>>>     setup.py
> >>>>     >>> packaging.
> >>>>     >>>
> >>>>     >>> On 11/27/2014 04:27 PM, Gabe Alford wrote:
> >>>>     >>>> Thanks guys. Sounds like it would be better to submit a patch
> >> that
> >>>>     >>> removes
> >>>>     >>>> app_PYTHON if it is considered dead code.
> >>>>     >>>>
> >>>>     >>>> Gabe
> >>>>     >>>>
> >>>>     >>>> On Thursday, November 27, 2014, Petr Spacek <
> >> pspacek at redhat.com
> >>>>     <mailto:pspacek at redhat.com>> wrote:
> >>>>     >>>>
> >>>>     >>>>> On 27.11.2014 11:00, Martin Basti wrote:
> >>>>     >>>>>> On 27/11/14 00:50, Gabe Alford wrote:
> >>>>     >>>>>>> Hello,
> >>>>     >>>>>>>
> >>>>     >>>>>>>        Wondering if I could get a review. Updated patch
> >>>>     attached.
> >>>>     >>>>>>>
> >>>>     >>>>>>> Thanks,
> >>>>     >>>>>>> Gabe
> >>>>     >>>>>>>
> >>>>     >>>>>>> On Tue, Nov 11, 2014 at 7:21 AM, Gabe Alford
> >>>>     <redhatrises at gmail.com <mailto:redhatrises at gmail.com>
> >>>>     >>>>> <javascript:;>
> >>>>     >>>>>>> <mailto:redhatrises at gmail.com <mailto:
> redhatrises at gmail.com
> >>>
> >>>>     <javascript:;>>> wrote:
> >>>>     >>>>>>>
> >>>>     >>>>>>>     Hello,
> >>>>     >>>>>>>
> >>>>     >>>>>>>     Fix for https://fedorahosted.org/freeipa/ticket/4700
> >>>>     >>>>>>>
> >>>>     >>>>>>>     Thanks,
> >>>>     >>>>>>>
> >>>>     >>>>>>>     Gabe
> >>>>     >>>>>>>
> >>>>     >>>>>>>
> >>>>     >>>>>>>
> >>>>     >>>>>> Hello,
> >>>>     >>>>>>
> >>>>     >>>>>> sorry for late response.
> >>>>     >>>>>>
> >>>>     >>>>>> We push this ticket to backlog, as it would be part of
> build
> >>>>     system
> >>>>     >>>>> refactoring.
> >>>>     >>>>>> The "app_PYTHON" statement is not used anymore in IPA, the
> >> better
> >>>>     >>>>> solution is
> >>>>     >>>>>> remove it, instead of keeping dead code up-to-date.
> >>>>     >>>>>
> >>>>     >>>>> Just to clarify:
> >>>>     >>>>> It can be pushed if it works, there is no need to postpone
> >>>>     accepting
> >>>>     >>> patch
> >>>>     >>>>> if
> >>>>     >>>>> the patch seems okay and doesn't break anything.
> >>>>     >>>>>
> >>>>     >>>>> Martin, please keep in mind that contributions are welcome
> at
> >>>>     any time.
> >>>>     >>>>>
> >>>>     >>>>> Milestones in Trac reflect our view of priorities but it
> >> doesn't
> >>>>     >>> prevent us
> >>>>     >>>>> from accepting correct patches from contributions at any
> >> time, no
> >>>>     >>> matter
> >>>>     >>>>> which
> >>>>     >>>>> priority is stated in Trac (or even if there is no ticket
> for
> >>>>     it ...).
> >>>>     >>>>>
> >>>>     >>>>> --
> >>>>     >>>>> Petr^2 Spacek
> >>>>
> >>>>     Worked in my tests, I did not see any breakage. I guess we can
> also
> >>>>     remove the
> >>>>     ipa-client/ipaclient/Makefile.am while we are at it.
> >>>>
> >>>>     Martin
> >>>>
> >>>>
> >>>> It looks like the ipaclient/Makefile.am is still being used. I tried
> >>>> removing it and there were errors in the build, but maybe I am wrong?
> >>>
> >>> It is needed to build ipa-join, ipa-getkeytab and ipa-rmkeytab.
> >>>
> >>> Feel free to rip out the outdated hg ChangeLog stuff though.
> >>>
> >>> rob
> >>
> >> I think Gabe was asking about ipa-client/ipaclient/Makefile.am and not
> >> about
> >> ipa-client/Makefile.am - we still need this one as Rob correctly said.
> >>
> >> The failure that Gabe hit in build probably comes from the the SUBDIR
> >> reference
> >> in ipa-client/Makefile.am file. I assume that if the reference is
> removed,
> >> the
> >> removal should work.
> >>
> >> And yes, you can remove the Changelog too if you are OK with it :)
> >>
> >> Martin
> >>
> >
>
> I think you did some error during the process. This is what I got:
>
> $ git clean -fxd
> $ git apply ...
> $ make rpms
> ...
> checking that generated files are newer than configure... done
> configure: creating ./config.status
> config.status: error: cannot find input file: `Makefile.in'
> Makefile:84: recipe for target 'client-autogen' failed
> make: *** [client-autogen] Error 1
>
> Martin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141203/8f481094/attachment.htm>