[Freeipa-devel] [PATCH 0074] Make token window sizes configurable

[Nathaniel McCallum]

On Thu, 2014-12-04 at 14:56 +0100, Petr Vobornik wrote:
> On 2.12.2014 20:57, Nathaniel McCallum wrote:
> > The attached patches I think have a much better overall aesthetic. Now
> > patch 0004 introduces only two new commands:
> > * otpconfig-mod
> > * otpconfig-show
> >
> > Under the covers, a single configuration entity is used:
> > * cn=otp,cn=etc,$SUFFIX
> >
> > Other than these small changes, there are no changes to patch 0004. I
> > have not tested the latest changes, however, due to an unrelated build
> > issue I'm working on.
> >
> > Patch 0005 introduces an umbrella help topic for all OTP related
> > commands (currently: otpconfig, otptoken, otptoken-yubikey).
> >
> > Nathaniel
> >
> 
> Works fine.
> 
> python part of 0004: ACK, but VERSION needs to be updated before push
> 0005: ACK

Fixed and rebased. Patch numbers have changed:
0004 => 0001
0005 => 0002

> One question before push: For per-token configuration, do you intent to 
> extend each token, regardless of type, by 'ipatokenOTPConfig' object 
> class? I.e. to have config attributes for both types? Or do you plan to 
> have special object classes for each token type as we now have for tokens?

I would probably just add the TOTP options to the ipatokenTOTP object
class as MAY. Same for HOTP. The attributes were designed to look like
the other token-type-specific attributes.

I think we are just waiting on Thierry's review of the C code. :)

Nathaniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-token-auth-and-sync-windows-configurable.patch
Type: text/x-patch
Size: 33054 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141204/a26e1fa5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Create-an-OTP-help-topic.patch
Type: text/x-patch
Size: 1801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141204/a26e1fa5/attachment-0001.bin>