[Freeipa-devel] [PATCH 3] ipa-client-install shouldn't be eager in specifying zone when doing nsupdate

[Martin Kosek]

On 12/04/2014 12:47 PM, Martin Basti wrote:
> On 04/12/14 10:03, Jan Pazdziora wrote:
>> On Wed, Dec 03, 2014 at 05:16:23PM +0100, Martin Basti wrote:
>>> On 02/12/14 13:00, Jan Pazdziora wrote:
>>>> Hello,
>>>>
>>>> presumably explicitly specifying zone is not needed and can be
>>>> harmful.
>>>>
>>> This should be fixed in template for uploading SSHFP keys as well.
>>>
>>> I have zone bububu.test.
>>>
>>> 2014-12-03T04:00:36Z DEBUG debug
>>> zone client.bububu.test.
>>> update delete test.client.bububu.test. IN SSHFP
>>> show
>>> send
>>> update add test.client.bububu.test. 1200 IN SSHFP 1 1
>>> 8FD003E98D818E4E2813672234410835AB5844AC
>>> update add test.client.bububu.test. 1200 IN SSHFP 1 2
>>> 37BF6366A44B67F6CA8FF8A8313B7C964CEA971CCB3E092D775FDF082170AAA4
>>> update add test.client.bububu.test. 1200 IN SSHFP 3 1
>>> 3651173F6737DF24EB6494434AC5968B3C90B749
>>> update add test.client.bububu.test. 1200 IN SSHFP 3 2
>>> 97EF4030A9DD471A3D4730A819B3A662E11994BB20AFC56FC3875AB1662260BF
>>> show
>>> send
>> Updated patch attached.
>>
> ACK
> I just removed unused dict value.
>
> @@ -1590,8 +1590,7 @@ def update_dns(server, hostname):
>
>       sub_dict = dict(HOSTNAME=hostname,
>                       IPADDRESS=ip,
> -                    TTL=1200,
> -                    ZONE='.'.join(hostname.split('.')[1:])
> +                    TTL=1200
>                   )
>
>       if af == socket.AF_INET:
>
>
> Patch with this update attached.

Pushed to:
master: bea417828d61777015785c716c4225bb48dcf037
ipa-4-1: 8b4301473233afdf0ae3c72ad33bcd04182e63c6