[Freeipa-devel] [PATCH 0162] Upgrade fix: masking named service should be executed only once

David Kupka dkupka at redhat.com
Tue Dec 9 08:51:19 UTC 2014


On 12/05/2014 12:58 PM, Martin Basti wrote:
> On 05/12/14 10:23, David Kupka wrote:
>> On 11/12/2014 01:43 PM, Martin Basti wrote:
>>> Hello,
>>>
>>> masking named service is executed more than once, following patch
>>> fixes it.
>>>
>>> Patch attached.
>>>
>>>
>>>
>>> _______________________________________________
>>> Freeipa-devel mailing list
>>> Freeipa-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>
>> Works as expected but:
>>
>> 0) mask_named_regular() returns True, False and None. None evaluates
>> as False so why not use False directly?
>> 1) missing link to ticket in commit message.
>>
>>
> Updated patch attached
>
Works for me, ACK.

-- 
David Kupka




More information about the Freeipa-devel mailing list