[Freeipa-devel] [PATCH 0082] Forward zones: add warning about forwarders semantic change in dnszone-add/mod

[Petr Viktorin]

On 07/03/2014 10:29 AM, Petr Spacek wrote:
> On 1.7.2014 17:23, Martin Basti wrote:
>> On Tue, 2014-07-01 at 12:17 +0200, Petr Viktorin wrote:
>>> On 07/01/2014 12:10 PM, Martin Basti wrote:
>>>> On Mon, 2014-06-30 at 13:57 +0200, Petr Viktorin wrote:
>>>>> On 06/30/2014 12:48 PM, Martin Basti wrote:
>>>>>> Ticket: https://fedorahosted.org/freeipa/ticket/3210#comment:16
>>>>>> Patch attached.
>>>>>>
>>>>>
>>>>> When you add a new message, you should also define a new class for
>>>>> it in
>>>>> messages.py with a new errno, not just reuse PublicMessage with a
>>>>> custom
>>>>> string.
>>>>>
>>>>>
>>>>
>>>> Could it be WarningMessage? Or should I be more specific
>>>> ForwardersWarningMessage, DNSSECWarningMessage ?
>>>
>>> Be specific. I'd go for DNSSECWarning; "message" is already in the
>>> module name.
>>>
>>>> Is there any rule how to choose errno?
>>>
>>> Just use the next unused one.
>>>
>>>
>> Updated patch attached
>
> ACK from functional perspective.
>
> It can be pushed if there is no problem with Python side of things.
>

Pushed to master: 33cf958b98dc2d80d17b3de1c145d403df4a3ba3


-- 
Petr³