[Freeipa-devel] [PATCH 0140] [PATCH 140/140] ipalib: Use DateTime parameter class for OTP token

Martin Kosek mkosek at redhat.com
Fri Jul 4 06:18:22 UTC 2014


On 07/03/2014 06:02 PM, Jan Cholasta wrote:
> On 3.7.2014 17:03, Petr Vobornik wrote:
>> On 2.6.2014 18:35, Petr Vobornik wrote:
>>> On 14.1.2014 15:20, Petr Viktorin wrote:
>>>> On 01/14/2014 09:33 AM, Jan Cholasta wrote:
>>>>> On 9.1.2014 16:32, Tomas Babej wrote:
>>>>>> Hi,
>>>>>>
>>>>>> For ipatokennotbefore and ipatokennotafter attributes use DateTime
>>>>>> parameter class instead of Str, since these are represented as
>>>>>> LDAP Generalized Time in LDAP.
>>>>>>
>>>>>> Tomas
>>>>>>
>>>>>
>>>>> ACK.
>>>>
>>>> This apparently depends on tbabej-0137, so let's not push it yet.
>>>>
>>>
>>> I've rebased the patch and wanted to push it but I found out, that in
>>> patch 138 - expose krbPrincipalExpiration we removed the "(UTC)" from
>>> labels [1].
>>>
>>> We should do the same here.
>>>
>>> [1] http://www.redhat.com/archives/freeipa-devel/2014-April/msg00442.html
>>>
>>
>> Since Tomas is on vacation, I've rebased it again and addressed ^^.
>>
>> If we want this change, it should be pushed before GA since it changes API.
>>
>> Web UI part is pvoborni-548-1
> 
> Thanks, ACK again.
> 

Pushed to master: 9bf29c270d703eeae5c0ccfe6b99cd7d1a8e8c86

Martin




More information about the Freeipa-devel mailing list