[Freeipa-devel] [PATCH] 0001 Fix ipa-client-install --uninstall crash

[David Kupka]

On 07/07/2014 09:15 PM, Petr Viktorin wrote:
> On 07/04/2014 08:47 AM, David Kupka wrote:
>> https://fedorahosted.org/freeipa/ticket/4273
>>
>> David Kupka
>
> Hi,
> This works fine. Just two nitpicks in the log message:
> - "%s" means "convert to string", so the str() is redundant
> - the logger methods take items to interpolate as arguments, instead 
> of one string built with %.
>
> So you'll want:
>     root_logger.error('Failed to start chronyd: %s', e)
>
>
Hi,
thanks for comments. I've fixed the patch accordingly.

-- 
David Kupka

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0001-2-Fix-ipa-client-install-uninstall-crash.patch
Type: text/x-patch
Size: 1199 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140708/ea45ee2d/attachment.bin>