[Freeipa-devel] [PATCHES] 0581-0582 ipalib.config: Only convert numeric values to float

Petr Viktorin pviktori at redhat.com
Mon Jun 16 11:39:39 UTC 2014


On 06/16/2014 07:04 AM, Fraser Tweedale wrote:
> On Fri, Jun 13, 2014 at 02:12:41PM +0200, Petr Viktorin wrote:
>> First patch: minor fix in env loading
>>
>> Second patch:
>>
>> When api.env is loaded, strings that "look like" floats get auto-converted
>> to floats. This is wrong, as the conversion can lose precision, which
>> matters for the new api_version.
>>
>> Here's a patch that disables this conversion, and fixes places that the
>> disabling might break.
>>
>> --
>> Petr³
>
> Changes look fine, apply fine, and ipalib tests pass.  ACK to both.

Thanks for the review!
Pushed to master: 521df77744233f424ec68caa68548bede6e575fb



-- 
Petr³




More information about the Freeipa-devel mailing list