[Freeipa-devel] [PATCH 0236] ipaldap: Fallback to string if datetime conversion went wrong

[Jan Cholasta]

Hi,

On 25.6.2014 17:17, Tomas Babej wrote:
> Hi,
>
> Our datetime conversion does not support full LDAP Generalized
> time syntax. In the unsupported cases, we should fall back
> to string representation of the attribute.
>
> In particular, '0' is used to denote no value of LDAP generalized
> time attribute.
>
> https://fedorahosted.org/freeipa/ticket/4350

NACK, this beats the purpose of decoding of the values, because it 
requires you to check the type of the value before using it.

Instead, you should either fix the code that uses the 
nsds5ReplicaLastUpdate{Start,End} attributes to access their raw value 
directly, or exclude the attributes from decoding to datetime by 
overriding their type in IPASimpleLDAPObject._SYNTAX_OVERRIDE.

Honza

-- 
Jan Cholasta