[Freeipa-devel] [PATCH 0251-0256] Add support for NSEC3

[Tomas Hozza]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/21/2014 11:33 AM, Petr Spacek wrote:
> On 7.5.2014 15:27, Petr Spacek wrote:
>> On 29.4.2014 23:34, Petr Spacek wrote:
>>> This patch set adds support for NSEC3. See commit messages for details.
>>
>> Patch 253 was obsoleted by patches 244v2 and 246v2.
>>
>> You can download latest & greatest version from dnssec branch on github:
>>
>> https://github.com/spacekpe/bind-dyndb-ldap/tree/dnssec
> 
> Patch 256v2 removes dead code from zone_master_reconfigure_nsec3param()
> function.
> 
> You can download latest & greatest version from dnssec branch on github.
> 
> This doesn't solve a race condition somewhere in start-up sequence, I'm
> looking into it.
> 

Hi.

I tested and reviewed patches 244-256 (all latest versions) and tested
the https://github.com/spacekpe/bind-dyndb-ldap/tree/dnssec HEAD.

Everything works as expected in constraints described in commit messages.

There is still a race condition with signing that Petr is aware of and
is working on it. (The zone is sometimes not signed if started using
systemd).

So I'm ACKing the patch-set 244-256

Regards,

Tomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTfJRdAAoJEMWIetUdnzwtzW0H/ifMHoW8p3gapxBxt3nmWtT4
rlGZAU0V9dwO8DAsEM2J73ZIehzoEPOX2c8CGqa3uZwuph9fH4gwqDOfw452ho5B
YqfI84hU18ncOHq5TXtu2SiwFqHWZveFATihx4Ds/Cg01KNSWeZ7bHzaaHQOlFOg
FFl7CAX5raNgIY97H1nJxs1AfmTWGFDC3oRDpbA1NXIYvWFprri/WNnREFNLTwsW
knxdxuS4pVpL9keQJUnQwbFbY12XqdGEhFgT8mwd0B9LEHsk1fTeat/P9rtOPPFF
ot81VoJ3bPs5eUZ9TdiyP4Ur6Y0fGfoIMUXTyDJ5/OarkOi+tAZoPLn1Gz60N3E=
=AWBQ
-----END PGP SIGNATURE-----