[Freeipa-devel] [PATCH 0269] Silence GCC warning about uninitialized ldap_writeback

[Petr Spacek]

On 24.6.2014 17:53, Lukas Slebodnik wrote:
> On (24/06/14 16:46), Petr Spacek wrote:
>> >Hello,
>> >
>> >Silence GCC warning about uninitialized ldap_writeback.
>> >
>> >It seems like false positive, I can't imagine how ldap_writeback could be
>> >used without prior initialization.
>> >
>> >--
>> >Petr^2  Spacek
>>From eb253b58d6214b3f94d22c3ec2dcf62d0103ad46 Mon Sep 17 00:00:00 2001
>> >From: Petr Spacek<pspacek at redhat.com>
>> >Date: Mon, 23 Jun 2014 17:02:08 +0200
>> >Subject: [PATCH] Silence GCC warning about uninitialized ldap_writeback.
>> >
>> >Signed-off-by: Petr Spacek<pspacek at redhat.com>
>> >---
>> >src/ldap_helper.c | 4 ++++
>> >1 file changed, 4 insertions(+)
>> >
>> >diff --git a/src/ldap_helper.c b/src/ldap_helper.c
>> >index 43bacf779f44a709b0cefd638826633b9d2d8891..a7a782fdfc5ae4d28b50155c9614d66a427dc3e0 100644
>> >--- a/src/ldap_helper.c
>> >+++ b/src/ldap_helper.c
>> >@@ -2130,7 +2130,11 @@ zone_sync_apex(const ldap_instance_t * const inst,
>> >	isc_boolean_t soa_tuple_alloc = ISC_FALSE;
>> >	isc_uint32_t curr_serial;
>> >
>> >+	REQUIRE(ldap_writeback != NULL);
>> >+
>> >	INIT_LIST(rdatalist);
>> >+	*ldap_writeback = ISC_FALSE; /* GCC */
>> >+
>> >	CHECK(setting_get_str("fake_mname", inst->local_settings,
>> >			      &fake_mname));
>> >	CHECK(ldap_parse_rrentry(inst->mctx, entry, &name, fake_mname,
>> >--
>> >1.9.3
>> >
> ACK

This is delayed push notice:
eb253b58d6214b3f94d22c3ec2dcf62d0103ad46

-- 
Petr^2 Spacek