[Freeipa-devel] [PATCH] 773-777 ranges: prohibit setting --rid-base with ipa-trust-ad-posix type

[Tomas Babej]

On 11/04/2014 01:05 PM, Petr Vobornik wrote:
>>>> On 10/15/2014 02:20 PM, Petr Vobornik wrote:
>>>>> ticket: https://fedorahosted.org/freeipa/ticket/4221
>>>>>
>
> updated version of patch 773 attached. Fixes issue in
> interactive_prompt_callback.
>
> Not related to this ticket:
> - should we show interactive prompt for domain name when user
> specifies --type=ipa-adtrust or ipa-adtrust-posix? Atm it will prompt
> for values related to local range.

ACK for the whole patchset, works in my testing.

Pushed to ipa-4-1: c2ac4a88775274e2cb8f199d104a1393a1d4a81e
Pushed to master: 8248f696275e2e63dab860a25467e2868aa17036

Regarding the issue, yes, I agree, prompting for values for the local
ranges should not happen. I think the most reasonable behaviour is as
follows:
 - first value that intractive callback asks for should be type, if not
specified or cannot be derived explicitly from used parameters (and
after the range's name)
 - after that, the interactive prompt should ask for relevant attributes
only.

-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org