[Freeipa-devel] [PATCH][bind-dyndb-ldap] AUTOCONF: Improve detection of bind9 header files

[Petr Spacek]

On 24.7.2014 11:00, Petr Spacek wrote:
> On 27.2.2014 15:19, Lukas Slebodnik wrote:
>> ehlo,
>>
>> I did some reviews of bind-dyndb-ldap last week  and it was little bit annoying
>> to export special CFLAGS for bind9 header files. It can be automatically
>> detected in configure script using utility isc-config.
>>
>> Attached patch should improve this and CFLAGS needn't be exported.
> 
> Kind NACK. It would be valuable to test if isc/errno2result.h header is
> present and throw appropriate error.
> 
> Current check with isc-config.sh only will pass if you have bind-devel package
> installed but you are missing bind-lite-devel package.
> 
> 
> I have a question: How
> +ldap_la_CFLAGS = $(BIND9_CFLAGS) -Wall -Wextra @WERROR@ -std=gnu99
> works?
> 
> Will it take user-defined CFLAGS into account? I would like to place
> user-defined flags at the end of the list so you can easily override settings
> given by autotools.
> 
> Thank you for clarification :-)
> 
> 
> I will be really happy to commit complete fix. Thank you for cleaning this
> autotools mess!

This version actually works. Previous version did not take CFLAGS from
isc-config.sh into account during libdns version check so it actually did not
work at all :-)

Please review it (and send me a modified patch if you see a problem).

Thank you for your time!

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bind-dyndb-ldap-lslebodn-0001-2-AUTOCONF-Improve-detection-of-bind9-header-files.patch
Type: text/x-patch
Size: 3227 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141112/23655f6b/attachment.bin>