[Freeipa-devel] [PATCH 0166] Workaround: warning if CA did not start at end of upgrade instead of raising error

[Simo Sorce]

On Wed, 19 Nov 2014 10:17:03 +0100
Martin Basti <mbasti at redhat.com> wrote:

> On 18/11/14 22:01, Martin Kosek wrote:
> > On 11/18/2014 08:20 PM, Martin Basti wrote:
> >> Ticket: https://fedorahosted.org/freeipa/ticket/4676
> >>
> >> Attached patches:
> >>
> >> * Version A: uses wget to get status of CA
> >> * Version B: write warning instead of raising exception (error is
> >> false positive, CA is running)
> >>
> >> I'm open to suggestions which approach is better
> >>
> >> Martin^2
> >>
> >
> > I like A, but I am concerned why you suddenly ignore the use_proxy 
> > option. I added it for a reason as it affects to which port we need
> > to connect, regardless the transport library. See
> >
> > https://fedorahosted.org/freeipa/ticket/3973
> >
> > where I added this option.
> >
> > Second, I am not happy by you duplicating the XML parsing code, I 
> > would rather see it splited in dogtag.py in separate 
> > "_ca_status_parse" or similar function call.
> >
> > Given the obstacles, I am inclining for
> > - pushing B as a safe fix for Fedora 21 Final
> > - fixing issues in A and pushing it for minor release after that to 
> > avoid the nasty warning and have some reasonable medium-term fix
> > until the framework migrates to something better than httpslib,
> > line python-requests maybe.
> >
> > Martin
> Sounds good to me.
> 
> Patch required for F21 attached. (with proper number)
> I will send the second patch after release for fedora (or should I
> sooner?) Martin^2
> 

Ack.

simo.

-- 
Simo Sorce * Red Hat, Inc * New York