[Freeipa-devel] [PATCH 0081] Add initial tests for OTP

Nathaniel McCallum npmccallum at redhat.com
Fri Nov 21 01:37:47 UTC 2014


On Thu, 2014-11-20 at 13:03 -0500, Nathaniel McCallum wrote:
> On Thu, 2014-11-20 at 17:32 +0100, Petr Viktorin wrote:
> > On 11/20/2014 05:13 PM, Nathaniel McCallum wrote:
> > > This tests the general workflow for OTP including most possible
> > > token combinations. This includes 5872 tests. Further optimization
> > > is possible to reduce the number of duplicate tests run.
> > >
> > > Things not yet tested:
> > > * ipa-kdb
> > > * ipa-otpd
> > > * otptoken-sync
> > > * RADIUS proxy
> > > * token self-management
> > > * type specific attributes
> > 
> > Hello,
> > This reimplements functionality that I'm changing in the pytest patches.
> > 
> > I'd like to rewrite these tests to use pytest best practices, both to 
> > make them work after the switch and as an example of pytest usage.
> > Would that work for you?
> 
> If you're volunteering, have at it!
> 
> Is there any planned functionality around parallelizing the tests? We
> could get a big speed boost, at least for these tests, by running token
> tests in parallel.

FYI, I fixed a bug with pyotp which caused failures with non-sha1
digests. https://github.com/nathforge/pyotp/pull/9

With this change, I did another run: 3.25 hours. Aside from some
spurious LimitsExceeded errors (which I get occasionally on my system;
it might be me), all tests passed.

Nathaniel




More information about the Freeipa-devel mailing list